Skip to content

Add resetFormatsAfterRequest issue test #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

Seros
Copy link

@Seros Seros commented Apr 17, 2025

@Seros Seros force-pushed the fix-kernel-boot branch 3 times, most recently from daa5190 to a14746f Compare April 17, 2025 09:45
@Seros Seros force-pushed the fix-kernel-boot branch from ea8d7b5 to 67b5402 Compare May 11, 2025 11:23
@TavoNiievez
Copy link
Member

@Seros I did a local checkout to your branch, installed dependencies and manually patched locally the changes in the module in your PR and I still see errors in the test execution.

Please, if this requires any additional steps not covered in the CI detail them so I can test.

@Seros
Copy link
Author

Seros commented May 12, 2025

I just did a clean checkout, executed the commands mentioned in the symfony.yml workflow, applied the changes from the module and run the tests. Everything looks fine. Which tests failed and what were the errors? Did you run php bin/console lexik:jwt:generate-keypair --skip-if-exists before?

@TavoNiievez
Copy link
Member

@Seros Thanks, I can now see that the test runs fine with your changes and fails without them.

However, in the output of vendor/bin/codecept run Functional I see the following:

[error] Uncaught PHP Exception ApiPlatform\Validator\Exception\ValidationException: "name: This value should not be null." at Validator.php line 58
[error] An exception occured, transforming to an Error resource.

[critical] Uncaught PHP Exception Symfony\Component\HttpClient\Exception\TransportException: "fopen(http://127.0.0.1/internal-endpoint): Failed to open stream" at ErrorChunk.php line 56

could you verify that your changes do not affect the other tests in the project?

@Seros
Copy link
Author

Seros commented May 15, 2025

Sure, I'll check this 👍

@TavoNiievez TavoNiievez changed the base branch from 6.4 to 6.4wApi May 15, 2025 22:05
@TavoNiievez TavoNiievez merged commit d358746 into Codeception:6.4wApi May 15, 2025
0 of 3 checks passed
@Seros
Copy link
Author

Seros commented May 16, 2025

Regarding An exception occured, transforming to an Error resource I checked and can say that this is no real issue. The ErrorListener is logging this for debug purposes. Not sure why it is logged as error though. See https://github.com/api-platform/symfony/blob/v4.1.9/EventListener/ErrorListener.php#L89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants